mad-star-studio/element-web
2
0
Fork 0
Code Pull requests Activity

Merge pull request #15345 from vector-im/t3chguy/fix/workbox

Browse source 
Disable workbox when running in webpack dev server, not in dev mode
This commit is contained in:
Michael Telatynski 2020-09-30 19:26:31 +01:00 • committed by GitHub
commit ca78985abc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/vector/platform/WebPlatform.ts
View file

@ -38,13 +38,17 @@ export default class WebPlatform extends VectorBasePlatform {
super();
// load service worker if available on this platform
// Service worker is disabled in development: https://github.com/GoogleChrome/workbox/issues/1790
if ('serviceWorker' in navigator && process.env.NODE_ENV === "production") {
navigator.serviceWorker.register('service-worker.js');
if ('serviceWorker' in navigator) {
// Service worker is disabled in webpack-dev-server: https://github.com/GoogleChrome/workbox/issues/1790
if (!process.env.WEBPACK_DEV_SERVER) {
navigator.serviceWorker.register('service-worker.js');
} else {
// we no longer run workbox when in webpack-dev-server, clean it up
navigator.serviceWorker.getRegistration().then(reg => reg && reg.unregister());
}
}
}
getHumanReadableName(): string {
return 'Web Platform'; // no translation required: only used for analytics
}