mad-star-studio/element-web
2
0
Fork 0
Code Pull requests Activity

Avoid re-rendering RoomList on room switch

Browse source 
See https://github.com/matrix-org/matrix-react-sdk/pull/1375
This commit is contained in:
David Baker 2017-09-11 17:06:40 +01:00
parent 079f39efed
commit 82f2e47667
2 changed files with 27 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/components/structures/RoomSubList.js
View file

@ -75,9 +75,6 @@ var RoomSubList = React.createClass({
order: React.PropTypes.string.isRequired,
// undefined if no room is selected (eg we are showing settings)
selectedRoom: React.PropTypes.string,
// passed through to RoomTile and used to highlight room with `!` regardless of notifications count
isInvite: React.PropTypes.bool,
@ -370,7 +367,6 @@ var RoomSubList = React.createClass({
var self = this;
var DNDRoomTile = sdk.getComponent("rooms.DNDRoomTile");
return this.state.sortedList.map(function(room) {
var selected = room.roomId == self.props.selectedRoom;
// XXX: is it evil to pass in self as a prop to RoomTile?
return (
<DNDRoomTile
@ -378,7 +374,6 @@ var RoomSubList = React.createClass({
roomSubList={ self }
key={ room.roomId }
collapsed={ self.props.collapsed || false}
selected={ selected }
unread={ Unread.doesRoomHaveUnreadMessages(room) }
highlight={ room.getUnreadNotificationCount('highlight') > 0 || self.props.isInvite }
isInvite={ self.props.isInvite }