Write additional tests (#22802)

* Write additional tests

* Make Sonar happier

src/vector/platform/IPCManager.ts

@@ -48,7 +48,7 @@ export class IPCManager {
         return deferred.promise;
     }
 
-    private onIpcReply = (ev: {}, payload: IPCPayload): void => {
+    private onIpcReply = (_ev: {}, payload: IPCPayload): void => {
         if (payload.id === undefined) {
             logger.warn("Ignoring IPC reply with no ID");
             return;

src/vector/platform/VectorBasePlatform.ts

@@ -47,7 +47,8 @@ export default abstract class VectorBasePlatform extends BasePlatform {
         if (this._favicon) {
             return this._favicon;
         }
-        return this._favicon = new Favicon();
+        this._favicon = new Favicon();
+        return this._favicon;
     }
 
     private updateFavicon() {

src/vector/platform/WebPlatform.ts

@@ -80,7 +80,7 @@ export default class WebPlatform extends VectorBasePlatform {
         // annoyingly, the latest spec says this returns a
         // promise, but this is only supported in Chrome 46
         // and Firefox 47, so adapt the callback API.
-        return new Promise(function(resolve, reject) {
+        return new Promise(function(resolve) {
             window.Notification.requestPermission((result) => {
                 resolve(result);
             });